More tolerant KNX component if gateway cant be connected#11511
Merged
balloob merged 2 commits intoJan 7, 2018
Conversation
…ng device cant be reached
…ant be connected
balloob
approved these changes
Jan 7, 2018
Merged
ghost
removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: fixes #11432
Current behavior: If the KNX tunelling cant be reached, an exception is thrown and no KNX device (lights, covers, etc) are initialized. This caused the side effect that homebridge loses some attributes which then have to be reconfigured manually.
Expected behaviour: All manually devices still show up - but are marked as not available.
This fix will not stop configuring the component if the gateway can't be reached. Instead it will show an error and mark all devices as not available.