Skip to content

Automatic cleanup of entity and device registry in AVM FRITZ!SmartHome#114601

Merged
mib1185 merged 8 commits into
home-assistant:devfrom
mib1185:fritzbox/automatic-cleanup-of-entity-and-device-registry
Apr 20, 2024
Merged

Automatic cleanup of entity and device registry in AVM FRITZ!SmartHome#114601
mib1185 merged 8 commits into
home-assistant:devfrom
mib1185:fritzbox/automatic-cleanup-of-entity-and-device-registry

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Apr 1, 2024

Proposed change

This will add an automatic cleanup of entity and device registry entries in case the user removes a device or template from the Fritz!Box or just reloads the config entry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Apr 1, 2024

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment thread homeassistant/components/fritzbox/coordinator.py Outdated
Comment thread homeassistant/components/fritzbox/coordinator.py Outdated
Comment thread homeassistant/components/fritzbox/coordinator.py Outdated
@mib1185 mib1185 requested a review from elupus April 20, 2024 09:34
Copy link
Copy Markdown
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mib1185 mib1185 merged commit 354c20a into home-assistant:dev Apr 20, 2024
@mib1185
Copy link
Copy Markdown
Member Author

mib1185 commented Apr 20, 2024

thx @elupus 👍

@mib1185 mib1185 deleted the fritzbox/automatic-cleanup-of-entity-and-device-registry branch April 20, 2024 10:14
@mib1185 mib1185 mentioned this pull request Apr 20, 2024
20 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2024
Comment thread homeassistant/components/fritzbox/coordinator.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Smarthome templates deleted in the FRITZ!Box UI are not removed from HomeAssistant

3 participants