Conversation
| """Initialize the data object.""" | ||
| self._hass = hass | ||
| self._datapoint = datapoint | ||
| self._hass = hass |
| data = MetOfficeCurrentData(hass, datapoint, site) | ||
| try: | ||
| data.update() | ||
| except (ValueError, dp.exceptions.APIException) as err: |
Member
There was a problem hiding this comment.
I don't think we should reraise the error in data.update. It's already logged there and raising it again will add an ugly stack trace to the log of it happens after setup_platform is finished.
Instead we can check if data.data is None, which it shouldn't be if everything is successful.
| def device_state_attributes(self): | ||
| """Return the state attributes of the device.""" | ||
| attr = {} | ||
| attr = dict() |
Member
There was a problem hiding this comment.
Why change this? I think the former is cleaner.
| 'visibility' in self.data.data.__dict__.keys()): | ||
| return VISIBILTY_CLASSES.get(self.data.data.visibility.value) | ||
| if self._condition in self.data.data.__dict__.keys(): | ||
| if self._condition in self.data.data.__dict__: |
Member
There was a problem hiding this comment.
You can use:
if hasattr(self.data.data, self._condition):
| def state(self): | ||
| """Return the state of the sensor.""" | ||
| if (self._condition == 'visibility_distance' and | ||
| 'visibility' in self.data.data.__dict__.keys()): |
Member
There was a problem hiding this comment.
Use:
hasattr(self.data.data, 'visibility'):
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add missing configuration variables.
Related issue (if applicable): fixes 37359
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4310
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass