Skip to content

Bump pychromecast to 14.0.1#113841

Merged
bdraco merged 1 commit into
devfrom
bump_pychromecast_14.0.1
Mar 19, 2024
Merged

Bump pychromecast to 14.0.1#113841
bdraco merged 1 commit into
devfrom
bump_pychromecast_14.0.1

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Mar 19, 2024 •
edited by bdraco
Loading

Proposed change

Bump pychromecast to 14.0.1

Changelog: https://github.com/home-assistant-libs/pychromecast/releases/tag/14.0.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2024.3.2 milestone Mar 19, 2024
@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: cast small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Mar 19, 2024
joostlek
joostlek approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also fix #113149

@emontnemery
Copy link
Copy Markdown
Contributor Author

emontnemery commented Mar 19, 2024

Doesn't this also fix #113149

Yeah, I forgot to tag it 👍

bdraco
bdraco approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, still works

Screenshot 2024-03-19 at 11 40 44 AM

@bdraco bdraco merged commit 8a9f69b into dev Mar 19, 2024
@bdraco bdraco deleted the bump_pychromecast_14.0.1 branch March 19, 2024 21:41
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdraco bdraco bdraco approved these changes

@joostlek joostlek joostlek approved these changes

Assignees

No one assigned

Labels

by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: cast Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2024.3.2

Development

Successfully merging this pull request may close these issues.

cast details for unknown model 'JBL Link Portable' Google Cast Cast.show_lovelace_view broken

4 participants

@emontnemery @bdraco @joostlek @balloob