Skip to content

Bump ical to 7.0.3 to fix local-todo persisted with invalid DTSTART values#113526

Merged
bdraco merged 3 commits into
home-assistant:devfrom
allenporter:todo-dtstart
Mar 16, 2024
Merged

Bump ical to 7.0.3 to fix local-todo persisted with invalid DTSTART values#113526
bdraco merged 3 commits into
home-assistant:devfrom
allenporter:todo-dtstart

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

@allenporter allenporter commented Mar 15, 2024

Proposed change

Bump ical to 7.0.3:
Release Notes: https://github.com/allenporter/ical/releases/tag/7.0.3
Full changelog: allenporter/ical@7.0.2...7.0.3

Previously this test fails with:

  Failed to validate: TZID=CST;20231024T113000, errors: (['Expected value to match DATE-TIME pattern: TZID=CST;20231024T113000', "Expected value to match DATE pattern: 'TZID=CST;20231024T113000'"]) (type=value_error)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Previously this test fails with:
  Failed to validate: 20231024T113000, errors: (["Expected DATE-TIME TZID value 'CST' to be valid timezone", "Expected value to match DATE pattern: '20231024T113000'"]) (type=value_error)
@allenporter allenporter marked this pull request as draft March 16, 2024 16:21
@allenporter
Copy link
Copy Markdown
Contributor Author

Looks like the tests are still failing

@allenporter allenporter marked this pull request as ready for review March 16, 2024 18:57
@allenporter
Copy link
Copy Markdown
Contributor Author

Fixed, I forgot to push the change to actually set 7.0.3 as the version (was still using 7.0.2 before)

@bdraco bdraco merged commit a9da9ee into home-assistant:dev Mar 16, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't recover two To Do lists previously available before 2024.3.0 & 2024.3.1. (See #112647)

3 participants