Skip to content

Bump pysnmp-lextudio to version 6.0.11#113463

Merged
bdraco merged 1 commit into
home-assistant:devfrom
lextm:dev
Mar 15, 2024
Merged

Bump pysnmp-lextudio to version 6.0.11#113463
bdraco merged 1 commit into
home-assistant:devfrom
lextm:dev

Conversation

@lextm
Copy link
Copy Markdown
Contributor

@lextm lextm commented Mar 14, 2024

Breaking change

Proposed change

As reported in #113457, a bug in pysnmp-lextudio prevents device tracker from working properly for many known SNMP devices (but a few might continue to work).

pysnmp-lextudio version 6.0.11 contains the fix.

While we are able to add new test cases to pysnmp package to confirm the bugfix, we are not yet familiar with home assistant setup to perform thorough testing.

changes: lextudio/pysnmp@v6.0.9...v6.0.11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: snmp small-pr PRs with less than 30 lines. Quality Scale: No score labels Mar 14, 2024
@bdraco bdraco added this to the 2024.3.2 milestone Mar 14, 2024
@bdraco bdraco changed the title Upgraded pysnmp-lextudio to version 6.0.11 Bump pysnmp-lextudio to version 6.0.11 Mar 14, 2024
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lextm

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Mar 14, 2024
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 15, 2024

Tested on prod. All good

@bdraco bdraco merged commit 92e7331 into home-assistant:dev Mar 15, 2024
@lextm
Copy link
Copy Markdown
Contributor Author

lextm commented Mar 15, 2024

@bdraco Thanks for accepting this.

BTW, what's your recommendation if we want to test out the latest dev branch to ensure everything works, not just unit testing? Should we set up Home Assistant differently from a method in https://www.home-assistant.io/installation/? Right now we are using a HA OS VM running on VirtualBox/macOS, but that does not seem to allow us to test the latest dev branch.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 15, 2024

If it's a container, I usually install nightly and swap out the code inside with something like

docker exec -it homeassistant /bin/bash

cd /usr/src
apk add autoconf automake libtool m4 gmp-dev mpfr-dev mpc1-dev gcc musl-dev openssl-dev libffi-dev ffmpeg-dev rust cargo zlib-dev jpeg-dev g++ make
git clone https://github.com/bdraco/home-assistant
mv homeassistant/ homeassistant.orig
mv home-assistant/ homeassistant
cd homeassistant
git checkout -t origin/integration
pip3 install --upgrade maturin
pip3 install --upgrade -r requirements.txt  --find-links=$WHEELS_LINKS -c ./homeassistant/package_constraints.txt
python3 -m script.translations develop --all

@lextm
Copy link
Copy Markdown
Contributor Author

lextm commented Mar 15, 2024

@bdraco Thank you very much. We will give that a try.

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: snmp Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNMP device tracker broken in 2024.3.1

3 participants