Check for EA release channel for UniFi Protect#113432
Merged
Merged
Conversation
Contributor
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
added 3 commits
March 14, 2024 12:02
bdraco
reviewed
Mar 14, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
reviewed
Mar 14, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
approved these changes
Mar 14, 2024
Member
|
Thanks @AngellusMortis |
Member
|
Tagging this for the next patch since unifi protect 3.x is in EA and we are seeing a lot of people upgrading and getting burned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Ubiquiti does not provide any official API or third-party support. They do not give open-source developers preview access to new versions to make their software compatible. They also do not have any kind of rules behind their versioning. A bugfix version can (and has) made breaking changes in the past.
As a result, any new version can break compatibility in unexpected ways. So, the UniFi Protect integration does not officially support any releases that are not on the official release channel to help mitigate this. Based on the fact that version 3.0.x has had 4 issues + numerous comments complaining about EA breaking their HA, the message is not being made clear enough to users that EA versions will eventually break their HA and they should not use them if they do not want HA to break.
This PR add an additional check for the release channel being used by the console, updates the messaging to be more specific that any release channel other than Official can break your HA integration as well as resets the EA warning prompt for all users to force them to accept it again. It also removes all references to manually downgrading since Ubiquiti does not want us to tell users to use
aptto downgrade and instead tells them to restore a backup, which is the "official" way of downgrading, even though Ubiquiti makes that really hard as well.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: