Skip to content

Check for EA release channel for UniFi Protect#113432

Merged
bdraco merged 6 commits into
home-assistant:devfrom
AngellusMortis:ufp-check-release
Mar 14, 2024
Merged

Check for EA release channel for UniFi Protect#113432
bdraco merged 6 commits into
home-assistant:devfrom
AngellusMortis:ufp-check-release

Conversation

@AngellusMortis
Copy link
Copy Markdown
Contributor

@AngellusMortis AngellusMortis commented Mar 14, 2024

Proposed change

Ubiquiti does not provide any official API or third-party support. They do not give open-source developers preview access to new versions to make their software compatible. They also do not have any kind of rules behind their versioning. A bugfix version can (and has) made breaking changes in the past.

As a result, any new version can break compatibility in unexpected ways. So, the UniFi Protect integration does not officially support any releases that are not on the official release channel to help mitigate this. Based on the fact that version 3.0.x has had 4 issues + numerous comments complaining about EA breaking their HA, the message is not being made clear enough to users that EA versions will eventually break their HA and they should not use them if they do not want HA to break.

This PR add an additional check for the release channel being used by the console, updates the messaging to be more specific that any release channel other than Official can break your HA integration as well as resets the EA warning prompt for all users to force them to accept it again. It also removes all references to manually downgrading since Ubiquiti does not want us to tell users to use apt to downgrade and instead tells them to restore a backup, which is the "official" way of downgrading, even though Ubiquiti makes that really hard as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment thread homeassistant/components/unifiprotect/strings.json Outdated
Co-authored-by: J. Nick Koston <nick@koston.org>
Comment thread homeassistant/components/unifiprotect/strings.json Outdated
Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 14, 2024

Thanks @AngellusMortis

@bdraco bdraco merged commit 1ada102 into home-assistant:dev Mar 14, 2024
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 14, 2024

Tagging this for the next patch since unifi protect 3.x is in EA and we are seeing a lot of people upgrading and getting burned

@bdraco bdraco added this to the 2024.3.2 milestone Mar 14, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants