Skip to content

Switch to gamertag#11315

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
ReneNulschDE:dev
Dec 27, 2017
Merged

Switch to gamertag#11315
pvizeli merged 1 commit into
home-assistant:devfrom
ReneNulschDE:dev

Conversation

@ReneNulschDE
Copy link
Copy Markdown
Contributor

@ReneNulschDE ReneNulschDE commented Dec 26, 2017

Description:

Switch to gamertag to receive ssl image URL

Related issue (if applicable):
fixes #7292, fixes #9412

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

No changes

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @ReneNulschDE,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff fabaff changed the title Bugfix for HA Issue 7292, 9412 - switch to gamertag to receive ssl im… Switch to gamertag Dec 26, 2017
@pvizeli pvizeli merged commit e5cc5a5 into home-assistant:dev Dec 27, 2017
@balloob balloob mentioned this pull request Jan 11, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xbox_live sensor profile images loaded over http: breaks https Xbox live sensor breaks https profile image loaded over http)

3 participants