Fix unpredictable entity names in concord232 binary_sensor#11292
Merged
MartinHjelmare merged 1 commit intoDec 25, 2017
Conversation
Contributor
rwa
changed the title
Member
|
Please add a comment to the release PR when that is opened, to highlight the change. |
MartinHjelmare
changed the title
MartinHjelmare
changed the title
balloob
pushed a commit
that referenced
this pull request
Jan 5, 2018
Merged
ghost
added
integration: concord232
and removed
platform: binary_sensor.concord232
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bug: When using the concord232 platform, binary_sensor entity names, e.g., binary_sensor.unnamed_device_2, can map to different sensors in the concord alarm system in an unpredictable way.
Fix: Sort the sensors by zone number right after they are queried. This gives both a predictable order and a simple mapping from zone numbers to entity numbering when the zones do not have names.
Related issue (if applicable): fixes #11289
I don't think new documentation is needed, but this should go in the release notes to explain the possibly changed behavior.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass