Greenwave Reality (TCP Connected) Lighting Component#11282
Merged
Conversation
houndci-bot
reviewed
Dec 23, 2017
| """Instruct the light to turn on.""" | ||
| import greenwavereality as greenwave | ||
| temp_brightness = int((kwargs.get(ATTR_BRIGHTNESS, 255) / 255) * 100) | ||
| greenwave.set_brightness(self._host, self._did, temp_brightness, self.token) |
There was a problem hiding this comment.
line too long (84 > 79 characters)
Line too long
pvizeli
reviewed
Dec 23, 2017
| / 255) * 100) | ||
| greenwave.set_brightness(self._host, self._did, | ||
| temp_brightness, self.token) | ||
| greenwave.turn_on(self._host, self._did, self.token) |
Member
There was a problem hiding this comment.
You are sure that is also need to send a brightness and after that also a on?
Contributor
Author
There was a problem hiding this comment.
Yes, both are required.
pvizeli
requested changes
Dec 23, 2017
| add_devices(TcpLights(device, host, token) for device in doc) | ||
|
|
||
|
|
||
| class TcpLights(Light): |
Member
There was a problem hiding this comment.
GreenwaveLight or like this. Other suggest that the class represent more than one light and run into name conflicts
Contributor
Author
There was a problem hiding this comment.
That was left over from when this was named TCP Lighting, changing it now.
| import greenwavereality as greenwave | ||
| import os | ||
| host = config.get(CONF_HOST) | ||
| tokenfile = hass.config.path('greenwave.token') |
Member
There was a problem hiding this comment.
use .greenwave so that should be not editable for users with a .
houndci-bot
reviewed
Dec 23, 2017
| else: | ||
| token = None | ||
| doc = greenwave.grab_xml(host, token) | ||
| add_devices(TcpLights(device, host, token) for device in doc) |
pvizeli
approved these changes
Dec 23, 2017
2 tasks
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created component to add support for End of Life Greenwave Reality (TCP Connected) gateway and lightbulbs
Description:
Related issue (if applicable): Added support for new platform
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.