Add button to homeworks #112269
Merged
Add button to homeworks #112269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
force-pushed
the
homeworks_button
branch
4 times, most recently
from
4480967
to
3427d97
Compare
emontnemery
force-pushed
the
homeworks_button
branch
from
3427d97
to
9c36176
Compare
jbouwh
requested changes
Mar 4, 2024
Comment on lines
-100
to
-104
| @property | ||
| def extra_state_attributes(self) -> dict[str, str]: | ||
| """Supported attributes.""" | ||
| return {"homeworks_address": self._addr} | ||
|
|
There was a problem hiding this comment.
Looks like an unrelated change
There was a problem hiding this comment.
This is moved to the base class so the same code is used both by the light and button entities:
I can drop it from this PR and add it in a separate PR though?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jbouwh
approved these changes
Mar 5, 2024
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add button entities to homeworks
The button entities allow triggering the actions bound to one of a keypad's momentary switches from Home Assistant
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: