Skip to content

Refactor file_upload to avoid janus dep#112032

Merged
bdraco merged 5 commits into
devfrom
file_upload_drop_janus
Mar 2, 2024
Merged

Refactor file_upload to avoid janus dep#112032
bdraco merged 5 commits into
devfrom
file_upload_drop_janus

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 2, 2024

Proposed change

Refactor file_upload to avoid janus requirement

The goal is to avoid the import cost of janus since file_upload is a dep of frontend

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 2, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (file_upload) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of file_upload can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign file_upload Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco marked this pull request as ready for review March 2, 2024 20:58
@bdraco bdraco requested a review from a team as a code owner March 2, 2024 20:58
@bdraco bdraco merged commit 546fc1e into dev Mar 2, 2024
@bdraco bdraco deleted the file_upload_drop_janus branch March 2, 2024 20:58
@MartinHjelmare
Copy link
Copy Markdown
Member

The PR description doesn't say what the import cost is.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 2, 2024

It was ~1.2s on my green, and ~0.4s on my more powerful x86_64 system

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants