Fix Shelly RPC RSSI sensor removal#111035
Merged
Merged
Conversation
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
|
Hey there @balloob, @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
a590212 to
2311660
Compare
bieniu
approved these changes
Feb 20, 2024
bdraco
approved these changes
Feb 21, 2024
Member
|
Thanks @thecode |
Member
|
Pulling this from the milestone, as it causes build issues (as it relies on other changes not in the current stable release for the tests). Will be part of 2024.3 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
#108390 removes the RPC (Shelly Gen2) RSSI sensor if the first WiFi station is disabled, Shelly Plus/Pro devices supports two WiFi connections and it is possible to enable the second one and disable the first one (I am using this as normal testing to cause a device to connect to a far AP).
https://shelly-api-docs.shelly.cloud/gen2/ComponentsAndServices/WiFi#configuration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: