Skip to content

Add Reolink hdd/sd card storage sensor#110961

Merged
edenhaus merged 7 commits into
home-assistant:devfrom
starkillerOG:reolink_hdd
Mar 21, 2024
Merged

Add Reolink hdd/sd card storage sensor#110961
edenhaus merged 7 commits into
home-assistant:devfrom
starkillerOG:reolink_hdd

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Feb 19, 2024

Breaking change

Proposed change

Add Reolink hdd/sd card storage sensor
As requested in #109487

Needs a version bump of reolink-aio to 0.8.8 from PR #110959

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG marked this pull request as ready for review February 19, 2024 20:39
@starkillerOG starkillerOG added the smash Indicator this PR is close to finish for merging or closing label Mar 6, 2024
Comment thread homeassistant/components/reolink/sensor.py
Comment thread homeassistant/components/reolink/sensor.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft March 6, 2024 08:52
@starkillerOG starkillerOG marked this pull request as ready for review March 9, 2024 20:00
@home-assistant home-assistant Bot requested a review from edenhaus March 9, 2024 20:00
Comment thread homeassistant/components/reolink/sensor.py Outdated
Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starkillerOG 👍

@edenhaus edenhaus merged commit cd934c2 into home-assistant:dev Mar 21, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants