Skip to content

Bump deluge-client to 1.10.2#110905

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
dsander:bump-deluge-client
Feb 19, 2024
Merged

Bump deluge-client to 1.10.2#110905
MartinHjelmare merged 1 commit into
home-assistant:devfrom
dsander:bump-deluge-client

Conversation

@dsander
Copy link
Copy Markdown
Contributor

@dsander dsander commented Feb 18, 2024

Breaking change

Proposed change

This mainly addresses the client hanging and not reconnecting whenever the deluge server is restarted. See JohnDoee/deluge-client#42.

JohnDoee/deluge-client@1.10.0...1.10.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This mainly addresses the client hanging and not reconnecting whenever
the deluge server is restarted. See JohnDoee/deluge-client#42

JohnDoee/deluge-client@1.10.0...1.10.2
@home-assistant home-assistant Bot added cla-needed dependency Pull requests marked as a dependency upgrade integration: deluge small-pr PRs with less than 30 lines. labels Feb 18, 2024
Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dsander

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft February 18, 2024 23:54
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (deluge) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of deluge can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign deluge Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dsander dsander marked this pull request as ready for review February 18, 2024 23:55
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 8e78710 into home-assistant:dev Feb 19, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2024
@home-assistant home-assistant unlocked this conversation Feb 21, 2024
@tkdrob
Copy link
Copy Markdown
Contributor

tkdrob commented Feb 21, 2024

Please add this to the next milestone. This should fix #111049.

@bdraco bdraco added this to the 2024.2.3 milestone Feb 21, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: deluge Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants