Dominos no order fix #10935
Dominos no order fix #10935
Conversation
homeassistant/components/dominos.py
Outdated
| try: | ||
| self.closest_store = self.address.closest_store() | ||
| except StoreException: | ||
| self.closest_store = Falsee |
homeassistant/components/dominos.py
Outdated
| for order_info in conf.get(ATTR_ORDERS): | ||
| order = DominosOrder(order_info, dominos) | ||
| entities.append(order) | ||
| if conf.get(ATTR_ORDERS) is not None: |
There was a problem hiding this comment.
I'd rather default to an empty list in the config schema and add a check below if entities is empty before adding them.
homeassistant/components/dominos.py
Outdated
| @@ -58,7 +58,8 @@ | |||
| vol.Required(ATTR_PHONE): cv.string, | |||
| vol.Required(ATTR_ADDRESS): cv.string, | |||
| vol.Optional(ATTR_SHOW_MENU): cv.boolean, | |||
| vol.Optional(ATTR_ORDERS): vol.All(cv.ensure_list, [_ORDERS_SCHEMA]), | |||
| vol.Optional(ATTR_ORDERS, default={}): vol.All( | |||
| menu = self.closest_store.get_menu() | ||
| product_entries = [] | ||
| return [] | ||
| else: |
There was a problem hiding this comment.
This else is not necessary because you return inside the if-statement.
* check for none * fix error from no store being set * typo * Lint * fix default as per notes. Lint fix and make closest store None not False * update default
|
Still the same after upgrading to 0.59.1 |
|
@Coolie1101 What does the error log look like now? Still a json.decoder.JSONDecodeError? |
|
No error's in log for Dominos, but Custom Panel is still blank. |
|
@Coolie1101 - would you mind trying to put this in your custom_components and see if it corrects the issue for you? https://gist.github.com/wardcraigj/1b215c680b0179d50c0f8f54c5e29510 |
|
|
Incidentally, that was already in my custom_components/sensor directory. Should I remove it? |
|
Yep, you can take it out of custom_components/sensor and put the one I linked to into custom_components/ The version I linked to is the version that will be in 0.58.2 so once that's out you can pull that version out of custom_components all together |
|
So, I upgraded to 0.59.2, and it looks like something is working, aa I get the following Warning: |
|
Yeah, that looks right, currently the store needs to be open in order to pull the menu. Try when the store opens and hopefully it works |
|
@wardcraigj: It's now 8:40 PM local time, the Dominos card displays as below, the custom panel is still blank, and my local store closes at 2:00AM
FYI, I'm not complaining in any way, just providing info in an effort to help troubleshoot potential issues, as this feature would be a great addition to automating, it's not critical that is work. Thanks for all your efforts. Let me know if there is anything else I should check. |
|
No support in PRs. |
Description:
Couple of small fixes for dominos component
Related issue (if applicable): fixes #10929
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass