Fix for time_date sensor #10694
Merged
Fix for time_date sensor #10694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
cgtobi
pushed a commit
to cgtobi/home-assistant
that referenced
this pull request
Nov 20, 2017
* fix to time_date sensor * cleaned up the code and added unit tests * fixed lint errors
balloob
pushed a commit
that referenced
this pull request
Nov 21, 2017
* fix to time_date sensor * cleaned up the code and added unit tests * fixed lint errors
Merged
|
is this a fix for the time date picker or is this picker still not available? |
|
The datetime_input should be "available". What bug are you experiencing? |
|
Not necessarily a bug, but the current method of entering a time is nearly impossible. A 0 gets added automatically at times, the field jumps from the hour to minute when you don’t want it to, and all of this is worse using the iOS app. I don’t know if there’s a better way to select a time that’s less frustrating, but it’s currently very difficult. Also, the calendar doesn’t display correctly with the iOS app. Only one week appears in the monthly popup and it’s difficult to scroll and pick the correct date. Maybe this is an iOS app bug?? |
|
Don't discuss unrelated topics in a PR |
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a fix to
dateoption oftime_datesensor.Related issue (if applicable): fixes #10477
Example entry for
configuration.yaml(if applicable): N/AChecklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass