Remove dead code in fibaro light

[rappenze]

Proposed change

Remove synchronization in fibaro light as it is not needed (anymore). I'm not sure why it was initially implemented but I tested it thoroughly and didn't find any reason for it.

Additionally it was needed to pass parameters to call_set_color in a different way because of mypy checks.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[HipsterBrown]

Remove synchronization in fibaro light as it is not needed (anymore). I'm not sure why it was initially implemented but I tested it thoroughly and didn't find any reason for it.

Based on other feedback I've gotten, since the pyfibaro action are blocking network I/O via the requests package, those actions should be deferred to the async executor to avoid blocking the event loop.

[frenck]

Thanks, @rappenze 👍

../Frenck

[MartinHjelmare]

Here's the explanation when the lock was added:
#18622 (comment)

Is that no longer the case?

[rappenze]

Here's the explanation when the lock was added: #18622 (comment)

Is that no longer the case?

This is no longer the case, in turn_on there is no case anymore which executes 2 requests so this change is safe.