Handle the new version of HydroQuebec website #10682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titilambert
force-pushed
the
hydroquebec
branch
from
09e6c49 to
4283b2f
Compare
| @@ -115,7 +116,7 @@ def setup_platform(hass, config, add_devices, discovery_info=None): | |||
| for variable in config[CONF_MONITORED_VARIABLES]: | |||
| sensors.append(HydroQuebecSensor(hydroquebec_data, variable, name)) | |||
|
|
|||
| add_devices(sensors, True) | |||
There was a problem hiding this comment.
How is the update call useless?
There was a problem hiding this comment.
It's just to speed up the startup of hass, the update can takes 10-20 seconds, and it's not needed to create sensors component in hass. So sensors will be updated later after the startup.
MartinHjelmare
approved these changes
Nov 20, 2017
balloob
pushed a commit
that referenced
this pull request
Nov 21, 2017
* Handle the new version of HydroQuebec website * Update requirements_all.txt
Merged
mderubertis
reviewed
Nov 29, 2017
| @@ -34,6 +34,7 @@ | |||
|
|
|||
| REQUESTS_TIMEOUT = 15 | |||
| MIN_TIME_BETWEEN_UPDATES = timedelta(hours=1) | |||
| SCAN_INTERVAL = timedelta(hours=1) | |||
There was a problem hiding this comment.
Would it be possible to add a force update or allow us to change the update interval?
|
If you need help please use our help channels: Merged PRs should not be used for support or bug reports. Thanks! |
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
HydroQuébec updated their website, this patch update the hydroquebec component to use the last version of pyhydroquebec
Also, this patch disabled the update on startup (this is useless) and set the default scan interval to 1 hour
Please merge also in the 0.58.1 (if this version is planned, Thanks !)
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.