Skip to content

Add alarm platform to Comelit#104718

Merged
chemelli74 merged 18 commits intohome-assistant:devfrom
chemelli74:chemelli74-comelit-alarm
Dec 26, 2023
Merged

Add alarm platform to Comelit#104718
chemelli74 merged 18 commits intohome-assistant:devfrom
chemelli74:chemelli74-comelit-alarm

Conversation

@chemelli74
Copy link
Copy Markdown
Contributor

@chemelli74 chemelli74 commented Nov 29, 2023

Breaking change

Proposed change

Add alarm platform to Comelit

Bump aiocomelit to 0.7.0:

changelog: https://github.com/chemelli74/aiocomelit/releases/tag/v0.7.0
diff: chemelli74/aiocomelit@v0.6.2...v0.7.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

home-assistant bot commented Dec 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 4, 2023 22:27
@chemelli74 chemelli74 requested a review from joostlek December 14, 2023 23:24
@chemelli74 chemelli74 marked this pull request as ready for review December 16, 2023 13:36
@chemelli74 chemelli74 force-pushed the chemelli74-comelit-alarm branch from 90ba44e to fd7c364 Compare December 16, 2023 15:47
@home-assistant home-assistant bot marked this pull request as draft December 19, 2023 13:14
@chemelli74 chemelli74 marked this pull request as ready for review December 19, 2023 17:07
@home-assistant home-assistant bot requested a review from joostlek December 19, 2023 17:07
@home-assistant home-assistant bot marked this pull request as draft December 23, 2023 22:48
@chemelli74 chemelli74 marked this pull request as ready for review December 24, 2023 16:30
@home-assistant home-assistant bot requested a review from joostlek December 24, 2023 16:30
@chemelli74 chemelli74 merged commit 2cd6c2b into home-assistant:dev Dec 26, 2023
@chemelli74 chemelli74 deleted the chemelli74-comelit-alarm branch December 26, 2023 17:27
@chemelli74
Copy link
Copy Markdown
Contributor Author

Thx!

@chemelli74 chemelli74 mentioned this pull request Dec 27, 2023
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants