Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev API docs from repository #102274

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Remove dev API docs from repository #102274

merged 2 commits into from
Oct 20, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 18, 2023

Proposed change

It isn't used, nor do we want to keep using this at this point.

The actual publishing of these docs has now been broken for 11 months and 3 weeks (at the time of writing).

Time to just clean it up.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed deprecation Indicates a breaking change to happen in the future Hacktoberfest small-pr PRs with less than 30 lines. labels Oct 18, 2023
@frenck frenck merged commit e6d9f89 into dev Oct 20, 2023
@frenck frenck deleted the frenck-2023-1279 branch October 20, 2023 06:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
@KapJI
Copy link
Member

KapJI commented Nov 10, 2023

@frenck Looks like this also removed screenshots which are used in root README.rst. Did no one noticed this in 3 weeks?

@frenck
Copy link
Member Author

frenck commented Nov 10, 2023

@KapJI Yes, there is a PR pending.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed deprecation Indicates a breaking change to happen in the future Hacktoberfest small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants