-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Add media position properties #10076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pvizeli
merged 11 commits into
home-assistant:dev
from
pschmitt:livebox-play-tv-media-position
Dec 13, 2017
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2579129
Add media progress information
pschmitt 9606212
Remove unnecessary comments
pschmitt 4906419
Remove datetime import
pschmitt e5ff3a6
Remove pysonyavr dependency
pschmitt 99ced74
Fix doc syntax (D205)
pschmitt 8b01324
Lint fix: no-else-return
pschmitt 093dce8
Don't attempt to set media progress info if program is None
pschmitt 6a5bcf6
Fix Python 3.4 compatibility
pschmitt 951ce74
Explicitely depend on pyteleloisirs
pschmitt 01ca064
Only update remaining play time when it changed
pschmitt bde6604
Fix floot state table
pvizeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should either expose
get_program_durationandget_remaining_timeoff of liveboxplaytv, or specifically call outpyteleloisirsin the requirements list since we're using it directly. We shouldn't implicitly depend on liveboxplaytv to pull in the requirement if we're calling it directly.