Skip to content

Add icons/logos for LD2450 BLE Custom Component#8015

Closed
jb1228 wants to merge 1 commit into
home-assistant:masterfrom
jb1228:ld2450_ble
Closed

Add icons/logos for LD2450 BLE Custom Component#8015
jb1228 wants to merge 1 commit into
home-assistant:masterfrom
jb1228:ld2450_ble

Conversation

@jb1228
Copy link
Copy Markdown

@jb1228 jb1228 commented Sep 29, 2025

Icons and logos for an LD2450 BLE custom integration, which is a newer model of the ld2410_ble (core integration) [#3925].

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
    • I've added a link to my custom integration repository in the PR description
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

- icon2x.png from app icon in Google Play store
- Resized 2x icon to normal icon for better quality
- Uses improved Hi-Link logos from #7832
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @jb1228 👋

Thanks for opening a pull request. However, the provided icons doesn't seem to match the manufacturer branding (but look like an application icon).

Please use the manufacturer branding instead.

Thanks! 👍

../Frenck

@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Oct 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft October 5, 2025 14:42
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 9, 2025

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

@frenck frenck closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants