Skip to content

Add branding for tomorrow.io by symlinking to climacell#2742

Merged
frenck merged 3 commits intohome-assistant:masterfrom
raman325:tomorrowio
Mar 19, 2022
Merged

Add branding for tomorrow.io by symlinking to climacell#2742
frenck merged 3 commits intohome-assistant:masterfrom
raman325:tomorrowio

Conversation

@raman325
Copy link
Copy Markdown
Contributor

Proposed change

ClimaCell as a company rebranded to Tomorrow.io right around when we introduced the climacell integration 🙃 After consulting some other members, I decided to build a new integration which is more or less a stripped down version of climacell (climacell supported two different APIs, this one only supports the one that's currently supported by the company). I've reached out to the company for updated branding but for now they are using their old logos, so symlinking should suffice

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symlink is created in an incorrect folder (root instead of the integrations folder)

@frenck frenck added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on labels Aug 16, 2021
@raman325 raman325 requested a review from frenck August 16, 2021 15:01
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Aug 16, 2021
@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Aug 16, 2021
@frenck frenck merged commit 0b117dd into home-assistant:master Mar 19, 2022
KartoffelToby pushed a commit to KartoffelToby/brands that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaits-parent Awaits the merge of an parent PR cla-signed has-parent This PR has a parent PR in a other repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants