Skip to content

Add Overkiz brand for new core integration#2478

Merged
frenck merged 1 commit intohome-assistant:masterfrom
iMicknl:overkiz
Dec 27, 2021
Merged

Add Overkiz brand for new core integration#2478
frenck merged 1 commit intohome-assistant:masterfrom
iMicknl:overkiz

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented Apr 18, 2021 •
edited
Loading

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

frenck
frenck requested changes Apr 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaced the old integration, right? Which needs to be cleaned up in that case as well?

@frenck frenck added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on labels Apr 19, 2021
@iMicknl
Copy link
Copy Markdown
Member Author

iMicknl commented Apr 19, 2021

This replaced the old integration, right? Which needs to be cleaned up in that case as well?

You are right. I was thinking about moving tahoma to custom_integrations, since there is still ha-tahoma that is utilising the TaHoma domain. Would that make sense? Or should I remove it in this PR.

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 19, 2021

Adding a custom integration is a separate PR and not related to core changes.

@iMicknl
Copy link
Copy Markdown
Member Author

iMicknl commented Apr 19, 2021

Adding a custom integration is a separate PR and not related to core changes.

Ok. I will remove tahoma in this PR, since that will be replaced by overkiz.

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Apr 30, 2021
frenck
frenck previously approved these changes Apr 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Apr 30, 2021
@iMicknl
Copy link
Copy Markdown
Member Author

iMicknl commented Dec 24, 2021

✅ Approved. Can be merged as soon as the parent PR gets merged.

Parent has been merged (#62640)

@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 24, 2021

@iMicknl Not need to mention/ping that stuff. Thanks 👍

@frenck frenck added the parent-merged The parent PR has been merged already label Dec 24, 2021
@frenck frenck merged commit 60744bf into home-assistant:master Dec 27, 2021
@iMicknl iMicknl deleted the overkiz branch December 27, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

awaits-parent Awaits the merge of an parent PR cla-signed has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iMicknl @frenck @homeassistant