Skip to content

Add and fix sony songpal#1515

Merged
frenck merged 1 commit into
home-assistant:masterfrom
shenxn:songpal
Apr 27, 2020
Merged

Add and fix sony songpal#1515
frenck merged 1 commit into
home-assistant:masterfrom
shenxn:songpal

Conversation

@shenxn
Copy link
Copy Markdown
Contributor

@shenxn shenxn commented Apr 26, 2020

Proposed change

Add logo to sony songpal and fix the folder name (sony_songpal -> songpal). I'm currently working on add config flow to the songpal integration and the logo and icon are needed.

Type of change

  • Add a new logo or icon for a new integration
  • Add a missing icon or logo for an existing integration
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request: #34714
  • Link to documentation pull request:
  • Link to integration documentation on our website:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't symlink files, only folders.
We don't have an integration with the domain sony, so the sony folder is now allowed to be here.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Apr 26, 2020
@shenxn
Copy link
Copy Markdown
Contributor Author

shenxn commented Apr 26, 2020

Now I simple copy the logo files from sony_projector to songpal.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shenxn! 👍

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Apr 27, 2020
@frenck frenck merged commit d7310f0 into home-assistant:master Apr 27, 2020
@shenxn shenxn deleted the songpal branch April 27, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants