Skip to content

Atag#1480

Merged
frenck merged 4 commits into
home-assistant:masterfrom
MatsNl:atag
Apr 22, 2020
Merged

Atag#1480
frenck merged 4 commits into
home-assistant:masterfrom
MatsNl:atag

Conversation

@MatsNl
Copy link
Copy Markdown
Contributor

@MatsNl MatsNl commented Apr 22, 2020

Proposed change

Icons and logos for new atag integration.

Type of change

  • Add a new logo or icon for a new integration
  • Add a missing icon or logo for an existing integration
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Related PRs:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Apr 22, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR @MatsNl!

Just 2 things:

  • Can the icon background be made transparent?
  • The logo has a lot of empty space around the logo, can we trim that down?

Thanks! 👍

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Apr 22, 2020
@MatsNl
Copy link
Copy Markdown
Contributor Author

MatsNl commented Apr 22, 2020

Done!

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Apr 22, 2020
@frenck frenck merged commit ba32549 into home-assistant:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants