Added Proliphix Brand images#1478
Merged
frenck merged 2 commits intoApr 22, 2020
Merged
Conversation
This was referenced Apr 22, 2020
frenck
requested changes
Apr 22, 2020
Member
frenck
left a comment
There was a problem hiding this comment.
The 2x versions look blown up. It is better to leave them out than to upscale.
Fall back to original icon instead of using upscaled versions.
Contributor
Author
|
Thanks for the advice, I removed the upscaled versions. For any other Brand PR's I open, I'll be sure to only include 2x version only if I am creating them from SVG directly (as with qBittorent integration) or they're available from the source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
icon.png)icon@2x.png)logo.png)logo@2x.png)