Skip to content

Added Proliphix Brand images#1478

Merged
frenck merged 2 commits into
home-assistant:masterfrom
LanceMcCarthy:lance/update-proliphix-brand-images
Apr 22, 2020
Merged

Added Proliphix Brand images#1478
frenck merged 2 commits into
home-assistant:masterfrom
LanceMcCarthy:lance/update-proliphix-brand-images

Conversation

@LanceMcCarthy
Copy link
Copy Markdown
Contributor

@LanceMcCarthy LanceMcCarthy commented Apr 22, 2020

Proposed change

Type of change

  • Add a new logo or icon for a new integration
  • Add a missing icon or logo for an existing integration
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • [ x] The added/replaced image(s) are PNG
  • [x ] Icon image size is 256x256px (icon.png)
  • [x ] hDPI icon image size is 512x512px for (icon@2x.png)
  • [x ] Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • [x ] hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2x versions look blown up. It is better to leave them out than to upscale.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Apr 22, 2020
Fall back to original icon instead of using upscaled versions.
@LanceMcCarthy
Copy link
Copy Markdown
Contributor Author

Thanks for the advice, I removed the upscaled versions.

For any other Brand PR's I open, I'll be sure to only include 2x version only if I am creating them from SVG directly (as with qBittorent integration) or they're available from the source.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LanceMcCarthy 👍

@frenck frenck merged commit 1a49083 into home-assistant:master Apr 22, 2020
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Apr 22, 2020
@LanceMcCarthy LanceMcCarthy deleted the lance/update-proliphix-brand-images branch April 22, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proliphix is missing brand images

2 participants