Skip to content

Add logo for numato integration#1119

Merged
frenck merged 2 commits into
home-assistant:masterfrom
clssn:numato
Apr 30, 2020
Merged

Add logo for numato integration#1119
frenck merged 2 commits into
home-assistant:masterfrom
clssn:numato

Conversation

@clssn
Copy link
Copy Markdown
Contributor

@clssn clssn commented Apr 11, 2020

Proposed change

Type of change

  • Add a new logo or icon for a new integration
  • Add a missing icon or logo for an existing integration
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the icon images as well?
As for the logo, please remove the whitespace around the actual logo.

Thanks 👍

@frenck frenck added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on labels Apr 11, 2020
@clssn
Copy link
Copy Markdown
Contributor Author

clssn commented Apr 11, 2020

@frenck not sure whether it's mandatory but I contacted the Numato company and got permission to use the logo as it is (unchanged) for the documentation. By the time I asked, I wasn't aware of the brands repo at all, so I missed that. So I might need to get back and ask them for an icon variant to use. Any suggestions?

@cogneato
Copy link
Copy Markdown
Contributor

@clssn After some poking around at their site, I found they have the icon available at many sizes (though the quality is not great)
image

I sized them to our specs and the rest of the logo is recreated using their own font details and colors. These should all be ready to go if you want to use them.
icon
icon@2x
logo
logo@2x

@clssn
Copy link
Copy Markdown
Contributor Author

clssn commented Apr 16, 2020

@cogneato thanks a lot! But now I'm confused, because the logo images you found (and those on their website) are using a different font, than the one they asked me to use unchanged (look at the M, very different): Numato logo with trademark (R). I'll push the logos you proposed as they are way better quality than the one they gave me, besides they're consistent with their website.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Apr 16, 2020
@clssn clssn marked this pull request as ready for review April 17, 2020 07:23
@clssn clssn requested a review from frenck April 30, 2020 19:00
@clssn
Copy link
Copy Markdown
Contributor Author

clssn commented Apr 30, 2020

Code is merged to dev now. Please merge this PR as well as appropriate. Thanks :-)

@frenck frenck merged commit dae7c8f into home-assistant:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants