Change exoplayer/play_hls payload type#932
Merged
JBassett merged 2 commits intohome-assistant:masterfrom Sep 16, 2020
Merged
Conversation
9 tasks
Contributor
Author
|
Since this is potentially breaking as the current app will not work with the new format of the call, we will temporarily remove ExoPlayer from the frontend side until this PR goes through and the app is updated. |
9 tasks
JBassett
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend may need to send additional options to the exoplayer/play_hls interface such as whether to be muted or not: home-assistant/frontend#6857 . With that in mind it is probably better to use a JSONObject instead of a String for the payload.