Server trust feature#3410
Merged
Merged
Conversation
dshokouhi
reviewed
Mar 8, 2023
dshokouhi
reviewed
Mar 8, 2023
JBassett
approved these changes
Mar 15, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a feature that allows you to (dis)trust a server, or as it is named in the app choose whether the server can remotely control the app & device.
With multiserver you might add servers to the app for convenient access or push notifications, but you don't want them to receive and manage (all) your sensors and device like for your primary server. You can already for example disable sensors for a particular server, but what is the point if you can turn them back on remotely? This could expose data you don't want to.
Disabling this option (default is enabled to match current behavior) will stop the following features:
As an intended side effect, when you don't trust a server and have disabled all sensors, the app will also stop fetching enabled sensors on the server in the worker (a request I've seen multiple times after it was added).
The goal is to have one toggle for all these 'remote control features'. A few users might want to fine tune the behavior but with the number of notification commands and other automatic integrations in the app this will quickly grow out of control.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#924
Any other notes