-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matter_server: Bump Python Matter server to 6.3.0 #3690
Conversation
Update to the lastest Python Matter server. This makes sure that the OTA Provider update binary is already part of the add-on so that updates can be tested in the upcomming beta phase. This also adds an option to set the Bluetooth adapter, which is useful to test local commissioning.
WalkthroughWalkthroughThe update to the Matter Server includes a version bump from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
matter_server/translations/en.yaml (1)
19-26
: Translation for new configuration key is incomplete.The
bluetooth_adapter_id
key has only been added to the English translation file. To maintain consistency and provide a complete user experience, please add this key to the other translation files.
- Ensure
bluetooth_adapter_id
is added to all other language translation files with appropriate translations.Analysis chain
Translation for new configuration key approved.
The addition of the
bluetooth_adapter_id
key with a clear description enhances user understanding of the new feature. Ensure that the translation aligns with other language versions if applicable.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the alignment of the translation with other language versions. # Test: Search for the new key in other translation files. Expect: Consistent descriptions across languages. rg --type yaml -A 5 $'bluetooth_adapter_id'Length of output: 781
Update to the lastest Python Matter server. This makes sure that the OTA Provider update binary is already part of the add-on so that updates can be tested in the upcomming beta phase.
This also adds an option to set the Bluetooth adapter, which is useful to test local commissioning.
Summary by CodeRabbit
New Features
bluetooth_adapter_id
for setting the BlueZ Bluetooth Controller ID.Documentation
6.3.0
with links to the release on GitHub.bluetooth_adapter_id
configuration option.Bug Fixes
Version Updates
6.3.0
in various files and configurations.