Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matter_server: Bump Python Matter server to 6.3.0 #3690

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

agners
Copy link
Member

@agners agners commented Jul 16, 2024

Update to the lastest Python Matter server. This makes sure that the OTA Provider update binary is already part of the add-on so that updates can be tested in the upcomming beta phase.

This also adds an option to set the Bluetooth adapter, which is useful to test local commissioning.

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration option bluetooth_adapter_id for setting the BlueZ Bluetooth Controller ID.
  • Documentation

    • Updated changelog to include version 6.3.0 with links to the release on GitHub.
    • Added documentation for the new bluetooth_adapter_id configuration option.
  • Bug Fixes

    • Enhanced script functionality to check for Bluetooth adapter ID and log primary network interface usage.
  • Version Updates

    • Updated Python Matter Server to version 6.3.0 in various files and configurations.

Update to the lastest Python Matter server. This makes sure that the OTA
Provider update binary is already part of the add-on so that updates can
be tested in the upcomming beta phase.

This also adds an option to set the Bluetooth adapter, which is useful
to test local commissioning.
Copy link
Contributor

coderabbitai bot commented Jul 16, 2024

Walkthrough

Walkthrough

The update to the Matter Server includes a version bump from 6.2.1 to 6.3.0. This new version adds support for configuring a Bluetooth adapter ID for local commissioning, enhances the build and configuration files to reflect the new version, and updates logging functionality to include Bluetooth adapter usage. Additionally, documentation and translations have been updated to reflect these changes.

Changes

File Path Summary
matter_server/CHANGELOG.md Added version 6.3.0 release information and updated the previous version 6.2.1 to include a GitHub release link.
matter_server/DOCS.md Introduced a new configuration option bluetooth_adapter_id for setting the BlueZ Bluetooth Controller ID for local commissioning.
matter_server/build.yaml Updated the python-matter-server container version for aarch64 and amd64 architectures from 6.2.1 to 6.3.0.
matter_server/config.yaml Updated the version to 6.3.0 and added a new configuration parameter bluetooth_adapter_id of type int.
matter_server/rootfs/.../run Added a conditional check for Bluetooth adapter ID in the configuration, logging the primary network interface, and sending discovery information to Home Assistant.
matter_server/translations/en.yaml Added configuration key bluetooth_adapter_id with properties for name and description related to the BlueZ Bluetooth Adapter Controller ID.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)
matter_server/translations/en.yaml (1)

19-26: Translation for new configuration key is incomplete.

The bluetooth_adapter_id key has only been added to the English translation file. To maintain consistency and provide a complete user experience, please add this key to the other translation files.

  • Ensure bluetooth_adapter_id is added to all other language translation files with appropriate translations.
Analysis chain

Translation for new configuration key approved.

The addition of the bluetooth_adapter_id key with a clear description enhances user understanding of the new feature. Ensure that the translation aligns with other language versions if applicable.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the alignment of the translation with other language versions.

# Test: Search for the new key in other translation files. Expect: Consistent descriptions across languages.
rg --type yaml -A 5 $'bluetooth_adapter_id'

Length of output: 781

@agners agners merged commit b06a02e into master Jul 16, 2024
10 checks passed
@agners agners deleted the bump-matter-server-to-6.3.0 branch July 16, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants