Username and password support for git_pull addon#217
Merged
Conversation
raiford
added a commit
to raiford/home-assistant.github.io
that referenced
this pull request
Dec 29, 2017
This is a documentation update that corresponds to home-assistant/addons#217
2 tasks
Member
|
Look nice, Can we merge that with #218 @lazytesting ? |
Contributor
Author
|
Sure, I can re-format my changes to match the new function layout that @lazytesting implemented. Should I wait until his changes are submitted to merge or is there a better way? |
Member
|
Please rebase this PR and applay last changes 👍 |
This can be used for private repositories that don't support ssh. Ex: https://cloud.google.com/source-repositories/docs/
raiford
force-pushed
the
git_pull_password
branch
from
5b0e0b0 to
a909a39
Compare
Contributor
Author
|
Ok, I rebased and updated it to follow the new format of the script. Please let me know what you think. |
pvizeli
approved these changes
Jan 17, 2018
Member
pvizeli
left a comment
pvizeli
left a comment
There was a problem hiding this comment.
Please update the CHANGELOG too
Member
|
now we wait for travis :) |
frenck
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Jan 24, 2018
This is a documentation update that corresponds to home-assistant/addons#217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic support for username and password authentication in the git_pull addon. This is necessary to use private repos that don't support ssh keys. An example of this is Google Cloud source repositories that use complex generated passwords for authentication over https.
https://cloud.google.com/source-repositories/
Doc update: home-assistant/home-assistant.io#4300