Skip to content

Rewrite release-assets action#68

Closed
cdce8p wants to merge 1 commit intohome-assistant:masterfrom
cdce8p:rewrite-release-assets
Closed

Rewrite release-assets action#68
cdce8p wants to merge 1 commit intohome-assistant:masterfrom
cdce8p:rewrite-release-assets

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Mar 16, 2022

Replaces #67

After the recent feedback, I've rewritten the release-assets action to be much versatile. E.g. it's now much easier to upload multiple files and reuse it in different repos.

Example job step for the frontend release action

      - name: Upload release assets
        uses: home-assistant/actions/helpers/release-assets@master
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          paths: "dist/"
          file_map: "*.whl=application/zip, *.tar.gz=application/gzip"

Example log output

-- Load list with existing assets
home-assistant-frontend-20220205.0.tar.gz [59714761]
home_assistant_frontend-20220205.0-py3-none-any.whl [59714693]
-- Delete assets
Delete asset with id 59714761
Delete asset with id 59714693
-- Find files
Paths: ['dist/']
File map: {'*.whl': 'application/zip', '*.tar.gz': 'application/gzip'}
Found 'dist/home-assistant-frontend-20220205.0.tar.gz' -> 'application/gzip'
Found 'dist/home_assistant_frontend-20220205.0-py3-none-any.whl' -> 'application/zip'
-- Upload assets
Successfully uploaded 'home-assistant-frontend-20220205.0.tar.gz'
Successfully uploaded 'home_assistant_frontend-20220205.0-py3-none-any.whl'

/CC: @ludeeus @balloob

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 17, 2022

Maybe this has been suggested/asked earlier before, so sorry if I raise duplicates: But why are we re-inventing the wheel here?

https://github.com/marketplace/actions/gh-release#%EF%B8%8F-uploading-release-assets

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 17, 2022

Maybe this has been suggested/asked earlier before, so sorry if I raise duplicates: But why are we re-inventing the wheel here?

https://github.com/marketplace/actions/gh-release#%EF%B8%8F-uploading-release-assets

Most actions, at least those I found and the one you linked, will create new releases instead of enabling the upload of files to existing ones.

There is one: https://github.com/actions/upload-release-asset, but as @ludeeus rightfully pointed out in #61 (comment) it's archived and unmaintained.

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 17, 2022

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 17, 2022

It takes the existing release into account: https://github.com/softprops/action-gh-release/blob/master/src/github.ts#L215

Fair enough, it works! Guess I should have done more research beforehand, would have saved me quite some time 😅
Anyway, I learned a lot. Basically, this here is all that's needed

      - name: Upload release assets
        uses: softprops/action-gh-release@v1
        with:
          files: dist/*

Example log output

♻️ Deleting previously uploaded asset home_assistant_frontend-20220205.0-py3-none-any.whl...
♻️ Deleting previously uploaded asset home-assistant-frontend-20220205.0.tar.gz...
⬆️ Uploading home_assistant_frontend-20220205.0-py3-none-any.whl...
⬆️ Uploading home-assistant-frontend-20220205.0.tar.gz...
🎉 Release ready at https://github.com/cdce8p/ha-frontend/releases/tag/v0.5.1

I'll update the Frontend PR. Once that is merged, I'll close the actions ones and remove the part which has already been merged.

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 23, 2022

No longer needed. See #69

@cdce8p cdce8p closed this Mar 23, 2022
@cdce8p cdce8p deleted the rewrite-release-assets branch March 23, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants