Return command status when setting a config parameter#177
Merged
MartinHjelmare merged 8 commits intoMar 25, 2021
Conversation
AlCalzone
reviewed
Mar 23, 2021
AlCalzone
reviewed
Mar 23, 2021
raman325
force-pushed
the
return_status
branch
3 times, most recently
from
4589b38 to
090fa14
Compare
|
|
||
| ACCEPTED = "accepted" | ||
| QUEUED = "queued" | ||
| FAILED = "failed" |
Contributor
There was a problem hiding this comment.
We don't seem to use the FAILED enum. Do we still need it?
Contributor
Author
There was a problem hiding this comment.
We can remove it. I was thinking it would be nice in the future if, for queued messages, we could support an optional callback in the future that returned the result once the message was processed which is why I had added this. But I will remove it for now and we can discuss that separately
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
…server-python into return_status * 'return_status' of https://github.com/raman325/zwave-js-server-python: Update test/util/test_node.py Update test/util/test_node.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cgarwood has requested that we have a way to know whether the command failed, was accepted, or was queued when setting a config parameter. This PR adds a status to the return which can be used in HA to get the status.
This should follow #176 so we can apply this to both utility functions