Exponential backoff of mdns service resolution retries#268
Merged
Conversation
emontnemery
force-pushed
the
mdns_backoff
branch
4 times, most recently
from
561125c to
6e87f11
Compare
emontnemery
force-pushed
the
mdns_backoff
branch
from
6e87f11 to
8ca26f1
Compare
balloob
reviewed
Feb 15, 2019
| # Resolve the service name. If service is None, we're | ||
| # connecting directly to a host name or IP-address | ||
| if service: | ||
| if now < retry['next_retry']: |
Contributor
There was a problem hiding this comment.
Why check this here instead of before creating a new socket and outside of the try?
Collaborator
Author
There was a problem hiding this comment.
Hmm, you're right.. Will fix.
balloob
approved these changes
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exponential backoff of mdns service resolution retries since each resolution request may generate a large number of packets with detrimental side effects.
Also:
See home-assistant/core#21075