Remove broken GDMDiscoverable.info_from_entry

[scop]

Another thing found while working on typing stuff. I have no way to test this, but while I believe this is correct in principle, it may also not solve the issue entirely it seems to me the dict may not always contain the accessed keys. In particular, is there a location key in the first place, or should Host be used instead? And isn't the other Port instead of port?

[balloob]

Well, if it ain't broken, don't fix it 😉

[scop]

The typing changes I've made will show that this is indeed broken, I'm just not sure what the complete correct fix would me. Would you prefer me to submit the typing stuff that demonstrates the breakage first?

[balloob]

GDM is used for Plex right? Although it does indeed look wrong (it's a dictionary and that's not how values are extracted), I think it works? 🤔

[balloob]

Ah, so just Plex uses it and Plex has implemented their own info_from_entry method. That's why. I think that we should just remove the method completely.

[scop]

I can modify this PR to remove the method if you like, but I have nothing to actually test this stuff with.

[balloob]

I would just remove it. It's not used and we wouldn't want to test it. GDM is a Plex specific discovery protocol 🤦‍♂️