Add an extra line for Shelly Plus 2PM (new model name)#376
Merged
thecode merged 2 commits intohome-assistant-libs:mainfrom Apr 18, 2023
Merged
Add an extra line for Shelly Plus 2PM (new model name)#376thecode merged 2 commits intohome-assistant-libs:mainfrom
thecode merged 2 commits intohome-assistant-libs:mainfrom
Conversation
bieniu
reviewed
Apr 14, 2023
thecode
requested changes
Apr 18, 2023
Co-authored-by: Shay Levy <levyshay1@gmail.com>
This was referenced Apr 18, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My new Shelly Plus 2PM`s model name is not recognised.
I found that there exist an entry for my model, but with model name SNSW-002P16EU.
My new shelly device has the model name SNSW-102P16EU.
Im short. I added a 2nd entry to const.py with the new model name and a trailing comment.
Everything else works as expected. The shelly status is printed.
Below is some of the output from running example.py before.
Below is some of the output from running example.py after.