Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat GPU data for HA and add unit test #35

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

wittypluck
Copy link
Contributor

The aim of this PR is to reformat the GPU data provided to Home Assistant, as discussed here:
home-assistant/core#106322 (comment)

The PR also adds default values to handle the case of missing sensors (as seen here : nicolargo/glances#170 (comment))

Also added unit test for GPU.

Copy link

@fhoekstra fhoekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Love the .get( safeguards

@wittypluck wittypluck marked this pull request as ready for review April 2, 2024 15:54
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 8f6c515 into home-assistant-ecosystem:master Apr 4, 2024
2 checks passed
@wittypluck wittypluck deleted the glances-ha-gpu branch July 24, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants