feat: map for entities and multiple map services
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxandersen
force-pushed
the
mapservices
branch
from
a7473dd to
f24add6
Compare
Why: * openstreetmap isn't always the best option. * there are more than just configuration with location info. This change addreses the need by: * introduce a `--service` option to let you choose which map service to use. currently: openstreetmap, google and bing implemented * add optional entity parameter to lookup and it has latitiude and longitude in its state it will be mapped. * bing has extra feature of allowing showing a name/label, here `friendly_name` is used otherwise `entity_id` Example usage: `hass-cli map person.max` `hass-cli --service bing device_tracker.maxs_phone` Future idea: allow to map multiple points, can be done as directions in google but Bing has better support.
maxandersen
force-pushed
the
mapservices
branch
from
f24add6 to
36aa941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This change addreses the need by:
--serviceoption to let you choose whichmap service to use. currently: openstreetmap, google and bing
implemented
latitiude and longitude in its state it will be mapped.
friendly_nameis used otherwiseentity_idFuture idea: allow to map multiple points, can be done as directions
in google but Bing has better support.