Skip to content

Add new switch color options for 0.101.x#5

Merged
pho3nixf1re merged 1 commit into
home-assistant-community-themes:masterfrom
TheZoker:patch-1
Oct 27, 2019
Merged

Add new switch color options for 0.101.x#5
pho3nixf1re merged 1 commit into
home-assistant-community-themes:masterfrom
TheZoker:patch-1

Conversation

@TheZoker
Copy link
Copy Markdown
Contributor

@TheZoker TheZoker commented Oct 24, 2019

Before (with 0.101.0b0):
Screenshot from 2019-10-24 16-34-49

After:
Screenshot from 2019-10-24 16-30-46

@pho3nixf1re
Copy link
Copy Markdown
Member

Please attach some screenshots to the PR as examples. Bonus points if you could submit updated screenshots for the README.

@TheZoker
Copy link
Copy Markdown
Contributor Author

I added the pictures. Actually nothing changes, there was just a change in parameter names:
home-assistant/frontend#3683

We can also remove the old ones:
https://github.com/home-assistant/home-assistant-polymer/pull/4017/files

@maartenpaauw
Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request! About the README screenshots; I've created a little script which will make them automatically. I can make them this weekend.

About removing the old variables. If you want you can create a separated PR.

@maartenpaauw
Copy link
Copy Markdown
Contributor

Screenshot tool: https://github.com/maartenpaauw/tiny-scripts/tree/master/theme-screenshot

I guess I have to add a README and default home assistant configuration soon! 😄

@pho3nixf1re pho3nixf1re merged commit 6d4cce8 into home-assistant-community-themes:master Oct 27, 2019
@TheZoker TheZoker deleted the patch-1 branch October 27, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants