Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yacd icon #871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add yacd icon #871

wants to merge 1 commit into from

Conversation

Flying-Tom
Copy link
Contributor

No description provided.

@Flying-Tom Flying-Tom force-pushed the add-yacd branch 2 times, most recently from db70754 to 519f8f8 Compare January 5, 2025 04:28
@stuntguy3000
Copy link
Collaborator

https://github.com/haishanh/yacd/blob/master/assets/yacd-128.png

This repository has a different version (and a few more...), is that the right icon?

svg/yacd.svg Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upload the actual icon as @stuntguy3000 suggested.

@Flying-Tom
Copy link
Contributor Author

haishanh/yacd@master/assets/yacd-128.png

This repository has a different version (and a few more...), is that the right icon?

Sorry for the late reply. This PR was denied previously by the owner because of the same reason.

Actually what I want to contribute to dashboard-icons is the haishanh/yacd@master/assets/apple-touch-icon-precomposed.png but not haishanh/yacd@master/assets/yacd-128.png. The reason is that the icon will be used when adding yacd as a PWA on ios and macos. But unfortunately it seems like yacd doesn’t provide HD png or svg of this icon, so I process it to meet the contribution rule.

Honestly, I also think this icon indeed should not be added as yacd, can a renaming as yacd-blue be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants