Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on Python 3.12 #863

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Run tests on Python 3.12 #863

merged 6 commits into from
Oct 2, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 2, 2023

No description provided.

@ianthomas23
Copy link
Member

It should be 3.12-dev rather than 3.12.

@ianthomas23
Copy link
Member

for the setup-python action I mean.

@maximlt
Copy link
Member Author

maximlt commented Oct 2, 2023

It should be 3.12-dev rather than 3.12.

Oh I didn't see your message, instead I just tried setting allow-prereleases to true for the setup-python action (https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#allow-pre-releases) and it seems it worked.

@philippjfr
Copy link
Member

Looks ready to merge, is it?

@maximlt
Copy link
Member Author

maximlt commented Oct 2, 2023

It is! Merging.

@maximlt maximlt merged commit f331087 into main Oct 2, 2023
@maximlt maximlt deleted the add_python_3.12 branch October 2, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximlt @ianthomas23 @philippjfr