Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for deserialization of file types into Array, DataFrame #482
Support for deserialization of file types into Array, DataFrame #482
Changes from 19 commits
eae3dc7
c158b90
88e29ba
87c05b8
0ab7ce0
61af683
2b76217
3c4ef0f
d2b0637
2ae5b1a
953d0bb
b437a8e
460bd25
f78b8d2
53e88fc
1d3b02c
724afd7
6890675
d16643a
53afaf7
3bbc03f
3dad451
edee35d
38a714b
1ba2664
c2646c2
e4d69b9
07e5818
c9c019d
40f8498
78afef9
c7f0326
15f7fd4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be ok with testing this new file-reading functionality only on pandas>=1.2; it's a new feature and not supporting it with old versions wouldn't be a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do, but I think this'll nix python 3.6? I think they only go up to 1.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with not supporting Python 3.6, since we are trying to merge this into Param 2, our forward-looking codebase.