Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set max-width: 100% on Tabulator table node #7626

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 17, 2025

Setting max-width: 100% (in #7425) inadvertently caused all kinds of issues for table rendering. This PR backs out of this change.

Fixes #7606, Fixes #7543, Fixes #7593

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (eda96ba) to head (1fec1e0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7626      +/-   ##
==========================================
+ Coverage   86.18%   86.72%   +0.54%     
==========================================
  Files         341      341              
  Lines       51772    51772              
==========================================
+ Hits        44619    44899     +280     
+ Misses       7153     6873     -280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 5283dab into main Jan 20, 2025
16 of 18 checks passed
@philippjfr philippjfr deleted the tabulator_table_max_width_unset branch January 20, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant