Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll when streaming to ChatFeed and ChatStep #7608

Merged
merged 10 commits into from
Jan 10, 2025
Merged

Conversation

philippjfr
Copy link
Member

It's a nicer experience to follow along while it's streaming though we should see if there's a mechanism to disable this behavior.

@ahuang11
Copy link
Contributor

ahuang11 commented Jan 9, 2025

Okay now it works like auto_scroll_limit:

  1. if scroll_limit = 0, then scroll_to_latest is disabled
  2. if scroll_limit is null, then scroll_to_latest will always trigger
  3. if scroll limit is set to a number > 0, it'll only stick to the bottom within the limit
demoo.mp4

@ahuang11 ahuang11 self-requested a review January 9, 2025 19:46
@ahuang11 ahuang11 marked this pull request as ready for review January 9, 2025 19:46
@ahuang11 ahuang11 added this to the v1.6.0 milestone Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 72.50000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.20%. Comparing base (55b0634) to head (ae16d20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/layout/test_feed.py 62.06% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7608      +/-   ##
==========================================
- Coverage   82.20%   82.20%   -0.01%     
==========================================
  Files         340      340              
  Lines       51487    51522      +35     
==========================================
+ Hits        42327    42355      +28     
- Misses       9160     9167       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 8662665 into main Jan 10, 2025
18 checks passed
@philippjfr philippjfr deleted the scroll_during_stream branch January 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants