Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_messages kwarg to Feed.add_step #7520

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add last_messages kwarg to Feed.add_step #7520

merged 2 commits into from
Dec 17, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Nov 25, 2024

In Lumen we loop thru the last five objects to search for the last steps object, but I think it can be baked into Panel.
https://github.com/holoviz/lumen/blob/main/lumen/ai/coordinator.py#L375-L380

@ahuang11 ahuang11 requested a review from philippjfr November 25, 2024 19:18
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (c6ac0a8) to head (b539685).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7520       +/-   ##
===========================================
+ Coverage   41.55%   82.38%   +40.82%     
===========================================
  Files         327      339       +12     
  Lines       48679    51016     +2337     
===========================================
+ Hits        20228    42027    +21799     
+ Misses      28451     8989    -19462     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 added this to the v1.5.5 milestone Dec 16, 2024
@philippjfr philippjfr merged commit a1882b4 into main Dec 17, 2024
16 of 18 checks passed
@philippjfr philippjfr deleted the add_last_messages branch December 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants