-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent tabulator from overlapping when max_height is set #7403
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7403 +/- ##
===========================================
+ Coverage 71.86% 82.23% +10.37%
===========================================
Files 336 337 +1
Lines 50542 50557 +15
===========================================
+ Hits 36320 41574 +5254
+ Misses 14222 8983 -5239 ☔ View full report in Codecov by Sentry. |
I think |
Also happy with this PR, but that might be simpler and clearer. |
serve_component(page, widget) | ||
|
||
table = page.locator('.pnx-tabulator') | ||
expect(table).not_to_have_css('max-height', '200px') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an odd test, why would I have max-height set to 200px in the first place? Seems like it should check that max-height is unset instead.
serve_component(page, widget) | ||
|
||
table = page.locator('.pnx-tabulator') | ||
expect(table).not_to_have_css('max-height', '200px') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay updated--seems counterintuitive to use to_have_css
to check for null, but I guess that's the only way!
* limit tabulator height with max height * use maxHeight config * reverse logic
Closes #7401
Before:
After, properly truncates
Does not use up all the space as max_height