Ensure Tabulator redraw is called after full render #7305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some major issues with the logic responsible for ensuring that the Tabulator was redrawn. In fact the logic was specifically skipping redraws if
this.tabulator != null
, so we never triggered the redraw at all since this completely incorrect PR 3 months ago: #6930Some additional improvements we make here:
root.has_finished
(i.e. the page is fully rendered).