-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easy to prompt user for input in ChatFeed #7148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
changed the title
Initial implementation of prompting for input
Make it easy to prompt for input in Chat
Aug 15, 2024
ahuang11
commented
Aug 15, 2024
ahuang11
commented
Aug 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7148 +/- ##
==========================================
+ Coverage 82.16% 82.19% +0.03%
==========================================
Files 328 328
Lines 49075 49206 +131
==========================================
+ Hits 40321 40446 +125
- Misses 8754 8760 +6 ☔ View full report in Codecov by Sentry. |
Bumps [ws](https://github.com/websockets/ws) from 8.17.0 to 8.18.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.17.0...8.18.0) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Screen.Recording.2024-08-16.at.10.02.16.PM.mov |
ahuang11
changed the title
Make it easy to prompt for input in Chat
Make it easy to prompt user for input in ChatFeed
Aug 17, 2024
philippjfr
reviewed
Aug 20, 2024
philippjfr
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7138
Inspired by https://discourse.holoviz.org/t/panel-chat-interface/7505?u=ahuang11
Wondering if the method should be renamed to simply
prompt
orprompt_user
orrequire_input
Screen.Recording.2024-08-14.at.5.11.51.PM.mov
I think this can also be generalized to allow editing existing ChatMessages.
Would like your feedback on this @MarcSkovMadsen and @philippjfr